[FIX] Selected messages don't get unselected #20408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellsh
approved these changes
Jan 26, 2021
| const reset = useMutableCallback(() => { | ||
| setSelected([]); | ||
| $(`#chat-window-${ rid }.messages-box .message.selected`) | ||
| $('.messages-box .message', $(`#chat-window-${ rid }`)) |
Member
There was a problem hiding this comment.
A simple space between them would have sufficed, but this achieves the same result. Thanks!
Contributor
Author
|
Hey @gabriellsh! Can you please merge this and review my other PRs so that I can make necessary changes and get them merged as well...? |
Member
|
@im-adithya Please, be patient. It'll be merged when it's supposed to. We review PRs as soon as we have enough time for it, no need to ask or tag anyone. Thanks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Rocket.Chat.-.Google.Chrome.2021-01-26.17-46-20.mp4
Issue(s)
This PR closes #20407
Steps to test or reproduce
Further comments